Re: [PATCH] emacs: Re-work the implementation of highlighting in notmuch-search-mode.

Subject: Re: [PATCH] emacs: Re-work the implementation of highlighting in notmuch-search-mode.

Date: Fri, 29 Oct 2010 15:33:28 -0700

To: David Edmondson, notmuch@notmuchmail.org

Cc:

From: Carl Worth


On Mon,  7 Jun 2010 15:35:10 +0100, David Edmondson <dme@dme.org> wrote:
> Re-write `notmuch-search-color-line', with the following improvements:
>  - create overlays only if they will be needed,
>  - merge the properties specified for a tag on top of any matching a
>    previous tag.
...
> +The attributes defined for matching tags are merged, with later
> +attributes overriding earlier. A message having both \"delete\"
> +and \"unread\" tags with the above settings would have a green
> +foreground and blue background."

Thanks David,

That looks like a very useful change. All pushed now.

(Though I don't yet have any automated tests to cover colors in emacs
buffers. Anyone care to cook something up?)

-Carl
part-000.sig (application/pgp-signature)

Thread: