Re: [PATCH] emacs: hello: make --batch error gracefully

Subject: Re: [PATCH] emacs: hello: make --batch error gracefully

Date: Sat, 27 Jul 2013 18:52:49 -0300

To: Mark Walters

Cc: notmuch mailing list

From: David Bremner


David Bremner <david@tethera.net> writes:

> I had a look at this, and I agree the current failure mode is not nice
> (it just says something mysterious about nil not being a string). On the
> other hand, I think we should use the two argument form of
> notmuch-logged-error, and the the first argument should say only what we
> know. Something like
>
> (notmuch-logged-error "notmuch count --batch failed"
> "notmuch count --batch failed
> Please check that the notmuch CLI is new enough to  support `count
> --batch'. In general we recommend running matching versions of the CLI
> and emacs interface.")

I pushed an amended version along these lines; it turns out the first
argument does not need to be repeated.

d

Thread: