Re: [PATCH] emacs: tree/show remove duplicate function

Subject: Re: [PATCH] emacs: tree/show remove duplicate function

Date: Mon, 14 Jul 2014 22:07:40 -0300

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: David Bremner


Mark Walters <markwalters1009@gmail.com> writes:
> +		   (cond ((eq major-mode 'notmuch-show-mode)
> +			  (notmuch-show-get-message-properties))
> +			 ((eq major-mode 'notmuch-tree-mode)
> +			  (notmuch-tree-get-message-properties))))

I see this already existed, but it looks weird to me to have a two test
cond with no else. Is it intentional to have the code drop through and
do nothing if neither case matches?  It seems like it might be better to
signal an error.

d

Thread: