Re: [PATCH] lib: index the content-type of the parts of encrypted messages

Subject: Re: [PATCH] lib: index the content-type of the parts of encrypted messages

Date: Fri, 15 Sep 2017 10:24:59 -0400

To: Jani Nikula

Cc: Notmuch Mail

From: Daniel Kahn Gillmor


On Fri 2017-09-15 10:48:08 +0300, Jani Nikula wrote:
> Nitpick, the extra braces aren't needed here. But the patch does what
> it says on the box.

Thanks for the review!

I prefer to keep the braces, i think they make it clearer what's
happening.  If whoever's merging prefers to remove the braces, i'd be
willing to accept that too.

This section is also updated in my cleartext-index series, which depends
on this cleanup series, so removing the braces will require yet another
rebase of that series, which is what i'd really like to get to.

> I was first wondering about the usefulness of indexing
> "application/octet-stream" for the encrypted content parts, but then I
> think it's good for completeness.

It would also make it possible to scan a maildir for encrypted messages
that *don't* have application/octet-stream for example, to see what is
going on there.

      --dkg
signature.asc (application/pgp-signature)
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: