Re: v4 flexible path location

Subject: Re: v4 flexible path location

Date: Sat, 20 Mar 2021 08:10:11 -0300



From: David Bremner

David Bremner <> writes:

> Since v3 [1]
> - rebase against the uncrustified version (unfortunately this makes an
>   interdiff too noisy to be helpful).
> - improve (?) the documentation of database.mail_root in notmuch-config(1).
> - tweak commit messages
> - move the call to _init_libs from [10/22] to [9/22]
> I'm going to mark this version as ready to apply, so object now, or
> grumble later.

Rebasing this on top of the hook fix, I noticed the following

diff --git a/lib/ b/lib/
index c9390359..8f572b0b 100644
--- a/lib/
+++ b/lib/
@@ -508,7 +508,7 @@ notmuch_database_open_with_config (const char *database_path,
     _set_database_path (notmuch, database_path);
-    status = _notmuch_choose_xapian_path (local, database_path,
+    status = _notmuch_choose_xapian_path (notmuch, database_path,
                                          &notmuch->xapian_path, &message);
     if (status)
        goto DONE;

Like all good memory bugs, this was mysteriously undetected until reopen
was called multiple times in the hook fix.

This is now fixed in my git repo. I'll hold off posting another series
for now.

notmuch mailing list --
To unsubscribe send an email to