Re: [PATCH v2 1/3] cli: refactor "notmuch tag" data structures for tagging operations

Subject: Re: [PATCH v2 1/3] cli: refactor "notmuch tag" data structures for tagging operations

Date: Mon, 26 Mar 2012 08:14:33 -0700

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins


On Sun, 25 Mar 2012 22:18:43 +0300, Jani Nikula <jani@nikula.org> wrote:
> To simplify code, keep all tagging operations in a single array
> instead of separate add and remove arrays. Apply tag changes in the
> order specified on the command line, instead of first removing and
> then adding the tags.
> 
> This results in a minor functional change: If a tag is both added and
> removed, the last specified operation is now used. Previously the tag
> was always added.

If this changes the behavior of notmuch then I think there should be a
test for it.  We should probably see a test for the current behavior,
and a modification of it to reflect whatever behavior is changing.

jamie.
part-000.sig (application/pgp-signature)

Thread: