Re: [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t

Subject: Re: [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t

Date: Wed, 26 Dec 2012 23:23:50 -0400

To: Michael Forney, Adrien Bustany,


From: David Bremner

Michael Forney <> writes:

> On Thu, 18 Oct 2012 00:52:20 +0300, Adrien Bustany <> wrote:
>> The code of the patches in unchanged, but the formatting issues are now
>> hopefully fixed.
> I would like to bump this patch set. I also need these features from
> libnotmuch. Currently there is no way to recover from Xapian errors,
> which is pretty limiting.
> If it is the flush/commit that is the issue, I would be happy to make an
> updated patch set.

Hi Michael;

Right, we should use the current name of 'commit'. We also need some way
to check the xapian version in the configure script, and to make sure
the right name is supported.

Jani refers to

farther up the thread as having some relevant code/ideas.

I think it's reasonable to require Xapian version at least 1.2.0, so
that might simplify the configuration check. 

The other thing I wondered is if the error handling in these routines is
as good as it could be. I guess it isn't worse than what is there, but
especially since you are explicitly wanting to handle error conditions,
it would be good to think if we can do something better than adding yet
another printf to the library.