Re: [PATCH] test: Port atomicity test to Python

Subject: Re: [PATCH] test: Port atomicity test to Python

Date: Sat, 04 Oct 2014 08:37:24 +0200

To: Austin Clements, notmuch@notmuchmail.org

Cc: Austin Clements

From: David Bremner


Austin Clements <aclements@csail.mit.edu> writes:

>
> Hi Amadeusz.  Does this patch fix the problem for you?  I don't have
> GDB 7.8, so I can't test against it, but the Python interface is less
> fragile than the GDB scripting language.  (Even if this doesn't fix
> your problem, I think we should switch to the Python interface.)

I can confirm this new version runs with gdb 7.8 (and python3) on
debian. I also runs with gdb 7.7.1+dfsg-3 and python2.

> +        shutil.copytree('%s/.notmuch' % maildir, '%s.snap/.notmuch' % maildir)

I hesitate to have an opinion on python style, but for whatever reason I
have a mild preference for str.format(args)  versus str % args. Not
enough of a preference to redo the patch.

I also agree that this version is easier to follow than the one it
replaces.

Thread: