Re: [PATCH 1/3] ruby: add database.revision

Subject: Re: [PATCH 1/3] ruby: add database.revision

Date: Mon, 29 May 2023 08:15:18 -0300

To: Felipe Contreras, notmuch@notmuchmail.org

Cc:

From: David Bremner


Felipe Contreras <felipe.contreras@gmail.com> writes:

> +
> +/*
> + * call-seq: DB.revision => Array
> + *
> + * Returns the commutted database revision and UUID.

typo.

> + */
> +VALUE
> +notmuch_rb_database_revision (VALUE self)
> +{
> +    notmuch_database_t *db;
> +    unsigned long rev;
> +    const char *uuid;
> +
> +    Data_Get_Notmuch_Database (self, db);
> +
> +    rev = notmuch_database_get_revision (db, &uuid);
> +    return rb_ary_new3(2, INT2FIX (rev), rb_str_new2 (uuid));
> +}

It _looks_ fine, but can we get a test in T395-ruby.sh to confirm?
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: