Re: [PATCH] emacs: `notmuch' should display the `notmuch-hello' interface

Subject: Re: [PATCH] emacs: `notmuch' should display the `notmuch-hello' interface

Date: Mon, 26 Apr 2010 10:41:59 -0700

To: David Edmondson, Dirk Hohndel, notmuch@notmuchmail.org

Cc:

From: Carl Worth


On Mon, 26 Apr 2010 17:30:04 +0100, David Edmondson <dme@dme.org> wrote:
> On Mon, 26 Apr 2010 09:11:07 -0700, Dirk Hohndel <hohndel@infradead.org> wrote:
> > This is lacking a committ message...

Thanks for the review, Dirk! Much appreciated.

> I wasn't sure what else to say.

Here's what I came up with in my --amend of the commit message:

    emacs: `notmuch' should display the `notmuch-hello' interface
    
    Reviewed-by: Carl Worth <cworth@cworth.org>
    
    The notmuch-hello functionality is now sufficiently useful that we
    want to make it the default view of notmuch for new users. This also
    effectively hides the "hello" name from the user, so we'll be free to
    change that in the implementation if necessary.
    
    This change also shuffles the requires between notmuch.el and
    notmuch-hello.el. This fixes things so that our documented (require
    'notmuch) is sufficient for getting the notmuch-hello functionality.
    
    Finally, the shuffling caused the notmuch-search-oldest-first variable
    from one file to the other. While doing that, give this variable the
    defcustom treatment for easier customization.

Pushed.

-Carl

-- 
carl.d.worth@intel.com
part-000.sig (application/pgp-signature)

Thread: