Re: [Patch] Fix Emacs interface bug dealing with invisible text

Subject: Re: [Patch] Fix Emacs interface bug dealing with invisible text

Date: Sun, 30 Oct 2011 10:58:55 +0100

To: Ivy Foster, notmuch@notmuchmail.org

Cc:

From: Thomas Jost


On Fri, 28 Oct 2011 20:29:49 -0400, Ivy Foster <joyfulgirl@archlinux.us> wrote:
> Hey, folks,
> 
> I'm new to notmuch, but like much of what I've tried so far.
> Thanks to all the contributors!
> 
> The following patch fixes a bug I've noticed in Emacs's
> notmuch-show mode. Specifically, if you:
> 
>     - have certain kinds of washing turned on (I've noticed
>       it with signature hiding), and
> 
>     - are looking at the last or only message in a thread
> 
> If you then hit Space (`notmuch-show-advance-or-archive') to
> move on, Emacs will fail to advance and/or archive the
> message, due to being kicked out of area of the invisible
> text before it can do what it's gotta do.
> 
> The patch should fix the problem at the root, which seems to
> be with notmuch-show-move-past-invisible-[forward|backward].

Hi Ivy,

Thanks for this patch. I haven't tested it, but I will!

However, I'm wondering something: wasn't this issue already addressed in
Dmitry's patch series that I rebased and reposted almost a month ago,
specifically patches 9/13 to 12/13?

Patch 9/13 of the rebased series is
id:"1317660447-27520-10-git-send-email-schnouki@schnouki.net".

Regards,
-- 
Thomas/Schnouki
part-000.sig (application/pgp-signature)

Thread: