Re: [PATCH v4 1/1] Make buttons for attachments allow viewing as well as saving

Subject: Re: [PATCH v4 1/1] Make buttons for attachments allow viewing as well as saving

Date: Fri, 20 Jan 2012 09:42:18 +0000

To: Austin Clements

Cc: notmuch@notmuchmail.org

From: Mark Walters


On Thu, 19 Jan 2012 23:30:23 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> One indentation nit and then this LGTM.
> 
> > +      (lexical-let ((message-id message-id)
> > +		    (nth nth)
> > +		    (filename filename)
> > +		    (content-type content-type))
> > +		   (flet ((mm-save-part (&rest args) (notmuch-show-save-part
> 
> This body of lexical-let should be indented like a normal let body.
> You might have to load cl to get this indentation rule.

Fixed. Patch to follow in reply.

Thanks

Mark

Thread: