Re: [PATCH 1/2] emacs/cli: remove entire-thread default from show: JSON

Subject: Re: [PATCH 1/2] emacs/cli: remove entire-thread default from show: JSON

Date: Thu, 23 Feb 2012 22:04:00 +0000

To: Adam Wolfe Gordon

Cc: notmuch@notmuchmail.org

From: Mark Walters

On Thu, 23 Feb 2012 14:45:57 -0700, Adam Wolfe Gordon <awg+notmuch@xvx.ca> wrote:
> Hi Mark,
> 
> On Thu, Feb 23, 2012 at 14:41, Mark Walters <markwalters1009@gmail.com> wrote:
> > Previously notmuch-show.c defaulted to --entire-thread when
> > format=json.  Make the default just the matching messages, but make
> > the single emacs caller add --entire-thread to the arguments supplied
> > so the end result should be unchanged.
> 
> The patch looks good to me. You should probably update the man page as
> well, to reflect the change in defauls.

Thanks for the review. I will include an updated man page in the next
version.

Many thanks

Mark

Thread: