Re: [PATCH] emacs: fix MML quoting in replies

Subject: Re: [PATCH] emacs: fix MML quoting in replies

Date: Mon, 05 Mar 2012 00:41:22 +0000

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: Mark Walters


On Sun,  4 Mar 2012 10:25:38 +0200, Jani Nikula <jani@nikula.org> wrote:
> The reply MML quoting added in commit ae438cc unintentionally MML
> quotes also the signature/encryption MML tags added via
> message-setup-hook, causing the reply not to be signed/encrypted.
> 
> MML quote just the original message in the temp buffer before
> inserting it to the message buffer, to not interfere with message mode
> hooks or message construction in general.
> 
> See [1] and [2] for bug reports.
> 
> Thanks to Tim Bielawa <tbielawa@redhat.com> for testing.
> 
> [1] id:"87hay78x6l.fsf@wyzanski.jamesvasile.com"
> [2] id:"1330812262-28272-1-git-send-email-tbielawa@redhat.com".


LGTM (but I am not really a lisper). I don't sign messages so haven't
tested it but it seems "correct" to only mml-quote the actual body
(i.e. the bit that comes from someone else).

Best wishes

Mark


Thread: