On Sat, 15 Dec 2012, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Sat, Dec 15 2012, Austin Clements <amdragon@MIT.EDU> wrote:
>
>> This provides library functions for unified handling of errors from
>> the notmuch CLI.  Follow-up patches will convert some scattered error
>> handling to use this and add error handling where we currently ignore
>> errors.
>> ---
>
> The series looks pretty good, some hardcoded patchs Mark noticed
> and it looks to me (after viewing id:8738z7hd6x.fsf@qmul.ac.uk
> that err -> nil could be done.

Fixed.

> Would (goto-char (point-min)) be needed before (insert msg) in
> this patch -- what If user has moved cursor while viewing old
> error messages but not pressed q (dismissed) on the buffer. 

Good idea.  Actually, I had intended to *append* the error to the buffer
so it would be in chronological order.  I tweaked things a bit so
messages should always be appended and point will be left at the end of
the error log.

> Also, what about (unless (eobp) (insert "\n")) to add empty
> line between error messages ?

Done.

> Tomi