Re: [PATCH 1/1] test: leave T\d\d\d- in variable $this_test and introduce $this_test_bare

Subject: Re: [PATCH 1/1] test: leave T\d\d\d- in variable $this_test and introduce $this_test_bare

Date: Tue, 14 Jan 2014 20:29:01 -0400

To: Tomi Ollila, notmuch@notmuchmail.org

Cc: tomi.ollila@iki.fi

From: David Bremner

Tomi Ollila <tomi.ollila@iki.fi> writes:

> Script `notmuch-test` expects the results file have T\d\d\d- part
> intact so the results files (and some test output files) are now named
> as such.
>
> The T\d\d\d- part is dropped in new variable $this_test_bare which is used
> in progress informational messages and when loading .el files in emacs
> tests (whenever $this_test_bare.el exists).

Should this commit message mention the bug it fixes?

Other than that the patch looks ok.

d

• Previous message (by thread): Re: [PATCH v2] test: leave T\d\d\d- in variable $this_test and introduce $this_test_bare

Thread:

• Tomi Ollila—[PATCH 1/2] test: basic: drop 'ensure all available tests are run' [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  • Tomi Ollila—[PATCH 2/2] test: renamed test scripts to format T\d\d\d-name.sh [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—Re: [PATCH 1/2] test: basic: drop 'ensure all available tests are run' [inbox, unread]
  • David Bremner—Re: [PATCH 1/2] test: basic: drop 'ensure all available tests are run' [inbox, unread]
  • Tomi Ollila—[PATCH 1/1] test: check that expected results file exists when test script exits != 0 [inbox, unread]
  • Tomi Ollila—[PATCH 1/1] test: leave T\d\d\d- in variable $this_test and introduce $this_test_bare [inbox, unread]
    • David Bremner—Re: [PATCH 1/1] test: leave T\d\d\d- in variable $this_test and introduce $this_test_bare [inbox, unread]
      • Tomi Ollila—[PATCH 1/1] test: check that expected results file exists when test script exits != 0 [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Tomi Ollila—[PATCH v2] test: leave T\d\d\d- in variable $this_test and introduce $this_test_bare [inbox, notmuch::patch, notmuch::pushed, notmuch::test, unread]
        • David Bremner—Re: [PATCH v2] test: leave T\d\d\d- in variable $this_test and introduce $this_test_bare [inbox, unread]