Re: [PATCH v2 06/16] Prefer gpg2 in the test suite if available

Subject: Re: [PATCH v2 06/16] Prefer gpg2 in the test suite if available

Date: Sun, 24 Jan 2016 11:03:22 -0500

To: Tomi Ollila, Notmuch Mail

Cc:

From: Daniel Kahn Gillmor

On Sun 2016-01-24 10:25:26 -0500, Tomi Ollila wrote:
> On Wed, Jan 20 2016, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:
>> --- a/test/test-lib.sh
>> +++ b/test/test-lib.sh
>> @@ -85,6 +85,13 @@ unset GREP_OPTIONS
>>  # For emacsclient
>>  unset ALTERNATE_EDITOR
>>  
>> +# choose the preferred GnuPG binary:
>> +if hash gpg2 2> /dev/null; then
>
> For consistency, instead of hash ... 2>/dev/null, use command -v >/dev/null

gotcha, i found several other instances of "command -v $whatever >
/dev/null" in the codebase already, so i'll stick with that.  updated in
my local copy now.

   --dkg

• Previous message (by thread): Re: [PATCH v2 06/16] Prefer gpg2 in the test suite if available

Thread:

• Daniel Kahn Gillmor—Allow indexing cleartext of encrypted messages (v2) [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v2 01/16] add util/search-path.{c, h} to test for executables in $PATH [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 02/16] Move crypto.c into libutil [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 03/16] make shared crypto code behave library-like [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 04/16] Provide _notmuch_crypto_{set,get}_gpg_path [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Tomi Ollila—Re: [PATCH v2 04/16] Provide _notmuch_crypto_{set,get}_gpg_path [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH v2 04/16] Provide _notmuch_crypto_{set,get}_gpg_path [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v2 05/16] Use a blank _notmuch_crypto to choose the default gpg_path [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 06/16] Prefer gpg2 in the test suite if available [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Tomi Ollila—Re: [PATCH v2 06/16] Prefer gpg2 in the test suite if available [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH v2 06/16] Prefer gpg2 in the test suite if available [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v2 07/16] create a notmuch_indexopts_t index options object [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 08/16] reorganize indexing of multipart/signed and multipart/encrypted [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 09/16] index encrypted parts when asked. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 10/16] Add n_d_add_message_with_indexopts (extension of n_d_add_message) [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 11/16] add --try-decrypt to notmuch insert [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 12/16] add --try-decrypt to notmuch new [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 13/16] add indexopts to notmuch python bindings. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 14/16] test indexing cleartext version of delivered messages. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 15/16] added notmuch_message_reindex [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 16/16] add "notmuch reindex" subcommand [inbox, notmuch::obsolete, notmuch::patch, unread]