Re: [PATCH v3 1/7] ruby: simplify data get helper

Subject: Re: [PATCH v3 1/7] ruby: simplify data get helper

Date: Mon, 17 May 2021 07:55:28 -0300

To: Felipe Contreras, notmuch@notmuchmail.org

Cc:

From: David Bremner


Felipe Contreras <felipe.contreras@gmail.com> writes:

> Data_Get_Struct is nothing but a macro that calls
> rb_data_object_get with a cast (unnecessary in C).
>
>         #define Data_Get_Struct(obj, type, sval) \
>             ((sval) = RBIMPL_CAST((type*)rb_data_object_get(obj)))
>
> We can use rb_data_object_get directly, and this way we don't need to
> pass the type, which is unnecessary information.

Thanks for the updated commit messages. Applied to master

d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: