Re: [PATCH 0/3] ruby: get rid of Tags object

Subject: Re: [PATCH 0/3] ruby: get rid of Tags object

Date: Sun, 02 Apr 2023 19:18:37 -0300

To: Felipe Contreras,

Cc: arcnmx

From: David Bremner

Felipe Contreras <> writes:

> We don't need a Tags enumerable object only for a small number of strings, we
> can just get them directly.
> This fixes an interaction problem where we might request two tags iterables
> from the same message:
>   tags_0 = notmuch_message_get_tags(message);

I have applied this series to master.

By the way I noticed that the formatting of the old bindings code does
not match the output of uncrustify -c ./devel/uncrustify/cfg $file.
This is not a serious problem, but it does make the review process a bit
noisy (since my clumsy script reformats every file touched by a given
commit). Do you have any objection to my just going through and
reformatting the bindings code with uncrustify at some point? It can be
done as patches also, but it's a bit silly because there can be many
small diffs.


notmuch mailing list --
To unsubscribe send an email to