Re: [PATCH v5] Add hook inside notmuch-mua-reply

Subject: Re: [PATCH v5] Add hook inside notmuch-mua-reply

Date: Tue, 19 Dec 2023 07:01:41 -0800

To: Sandra Snan, notmuch@notmuchmail.org

Cc:

From: David Bremner


Sandra Snan <sandra.snan@idiomdrottning.org> writes:

> This hook is run after `notmuch reply` has been successfully called
> with the headers from the original message.


It seems like the commit message should be updated to match the changes
in the patch. With my "editor" hat on, it's also a bit ambigous what
"with the headers from the original message" applies to; it could be
read as `notmuch reply`

It would be nice to mention the motivation for the change (e.g. to
enable autocrypt). Our usual mantra (not _always_ followed, but we try),
is to say something about the "why" as well as the "what".

Thanks for your efforts,

David

_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: