Re: [Brennan Vincent] Re: [PATCH v2] Add --emit-message-id flag to notmuch-insert.

Subject: Re: [Brennan Vincent] Re: [PATCH v2] Add --emit-message-id flag to notmuch-insert.

Date: Fri, 27 Sep 2024 19:59:14 -0300

To: Brennan Vincent, notmuch@notmuchmail.org

Cc:

From: David Bremner


"Brennan Vincent" <brennan@umanwizard.com> writes:

>> Since notmuch is already a talloc context, you should address the need
>> for a new context somewhere (either a comment or the commit message).
> I don't remember why I did this. I've never used talloc before and
> probably just got confused. I'll switch to using notmuch.

I should have been more explicit. There is a good reason, namely the
lifetime of those temporary strings is much shorter when using the
"local" talloc context, but I had to stare at it a bit to figure that out.
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: