Re: [notmuch] [PATCH] notmuch-new: Eliminate gcc warning caused by ino_cmp.

Subject: Re: [notmuch] [PATCH] notmuch-new: Eliminate gcc warning caused by ino_cmp.

Date: Mon, 23 Nov 2009 03:38:25 +0100

To: Jan Janak, notmuch@notmuchmail.org

Cc:

From: Carl Worth


On Sun, 22 Nov 2009 13:32:36 +0100, Jan Janak <jan@ryngle.com> wrote:
> The function passed to scandir in the fourth argument takes two
> const void* arguments. To eliminate the gcc warning about incompatible
> types, we change ino_cmp to match this and then re-type the parameters
> in the body of ino_cmp.

Actually, on my system at least, (Linux with glibc 2.10.1), our current
function matches the prototype. So applying your patch actually
*introduces* a warning where there was no warning before.

What a nuisance...

Any ideas for a good fix, anyone?

-Carl

Thread: