Re: [PATCH] Always return the empty string if decryption tries to demand a password

Subject: Re: [PATCH] Always return the empty string if decryption tries to demand a password

Date: Fri, 03 Jun 2011 16:15:14 -0700

To: Daniel Kahn Gillmor, notmuch@notmuchmail.org

Cc: Daniel Kahn Gillmor

From: Carl Worth

On Fri,  3 Jun 2011 19:03:08 -0400, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:
> The notmuch binary is not in the business of doing interactive
> prompting with the user.  If credentials are needed for decryption,
> they should be supplied to the decrypting processes some other way
> (e.g. gpg-agent).
> 
> Previously, we returned a NULL function pointer for the
> request_passwd() function, which may have cause segmentation faults
> with some versions of gmime.

Cool. This fixes my segfaults, so thanks!

> +    return g_strdup ("");

Is the above correct? Or is it a memory leak? (If it's not a leak, then
GMime really has some bizarre ownership semantics.)

-Carl

• Previous message (by thread): Re: [PATCH] Use stock GMimeSession by default

Thread:

• Jameson Graef Rollins—New crypto patch series [inbox, unread]
  • Jameson Graef Rollins—[PATCH 01/11] Simplify reply_part function to eliminate redundant code paths. [inbox, unread]
  • Jameson Graef Rollins—[PATCH 02/11] Integrate reply_part_content function into reply_part function. [inbox, unread]
  • Jameson Graef Rollins—[PATCH 03/11] Use empty strings instead of NULL in format_reply structure. [inbox, unread]
  • Jameson Graef Rollins—[PATCH 04/11] Break up format->part function into part_start and part_content functions. [inbox, unread]
  • Jameson Graef Rollins—[PATCH 05/11] test: new test-lib function to test for equality between files [inbox, unread]
  • Jameson Graef Rollins—[PATCH 06/11] test: add notmuch_show_sanitize_all function that is a little more aggressive. [inbox, unread]
  • Jameson Graef Rollins—[PATCH 07/11] test: add crypto tests for signature verification and decryption [inbox, unread]
  • Jameson Graef Rollins—[PATCH 08/11] Add signature verification of PGP/MIME-signed parts with --verify. [inbox, unread]
  • Jameson Graef Rollins—[PATCH 09/11] Add decryption of PGP/MIME-encrypted parts with --decrypt. [inbox, unread]
  • Jameson Graef Rollins—[PATCH 10/11] emacs: Add support for PGP/MIME verification/decryption [inbox, unread]
  • Jameson Graef Rollins—[PATCH 11/11] tag signed/encrypted during notmuch new [inbox, unread]
  • Jameson Graef Rollins—normalizing part numbering across PGP/MIME processing [inbox, unread]
    • Jameson Graef Rollins—[PATCH 1/4] Do not replace multipart/signed part with content part when doing verification. [inbox, unread]
      • Jameson Graef Rollins—[PATCH 2/4] Render all parts of multipart/encrypted when decrypting. [inbox, unread]
        • Jameson Graef Rollins—[PATCH 3/4] emacs: Do not attempt to render arbitrary application parts. [inbox, unread]
          • Jameson Graef Rollins—[PATCH 4/4] emacs: Give mutlipart/{signed, encrypted} their own part handler. [inbox, unread]
            • Jameson Graef Rollins—[PATCH] emacs: Give mutlipart/{signed, encrypted} their own part handler. [inbox, unread]
    • Daniel Kahn Gillmor—Re: normalizing part numbering across PGP/MIME processing [inbox, signed, unread]
    • Carl Worth—Re: normalizing part numbering across PGP/MIME processing [inbox, signed, unread]
      • Jameson Graef Rollins—Re: normalizing part numbering across PGP/MIME processing [inbox, signed, unread]
        • Carl Worth—Re: normalizing part numbering across PGP/MIME processing [inbox, signed, unread]
      • Daniel Kahn Gillmor—[PATCH] Always return the empty string if decryption tries to demand a password [inbox, unread]
        • Carl Worth—Re: [PATCH] Always return the empty string if decryption tries to demand a password [inbox, signed, unread]
          • Daniel Kahn Gillmor—Re: [PATCH] Always return the empty string if decryption tries to demand a password [inbox, signed, unread]
            • Daniel Kahn Gillmor—[PATCH] Use stock GMimeSession by default [inbox, unread]
              • Daniel Kahn Gillmor—[PATCH] Use stock GMimeSession by default [inbox, unread]
                • Carl Worth—Re: [PATCH] Use stock GMimeSession by default [inbox, signed, unread]