Re: [PATCH 3/4] emacs: tree: add sort argument to notmuch-tree

Subject: Re: [PATCH 3/4] emacs: tree: add sort argument to notmuch-tree

Date: Sat, 01 Aug 2015 07:49:09 +0200

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: David Bremner


Mark Walters <markwalters1009@gmail.com> writes:

> +  OPEN-TARGET: If TRUE open the target message in the message pane.
> +  OLDEST-FIRST: If TRUE display threads sorted oldest first"
> +  (interactive
> +   (list
> +    ;; Prompt for a query
> +    nil
> +    ;; use default search order
> +    nil nil nil nil (default-value 'notmuch-search-oldest-first)))

This is probably just me being ignorant, but I had to check the docs for
this usage of interactive. If you think it's tricky also, might be worth
a brief comment.

Otherwise the series looks ok to me.

Thread: