Re: [PATCH 2/2] cli/count: apply uncrustify changes

Subject: Re: [PATCH 2/2] cli/count: apply uncrustify changes

Date: Wed, 09 Sep 2015 14:36:01 -0300

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: David Bremner


Tomi Ollila <tomi.ollila@iki.fi> writes:

>>  
>>      if (exclude == EXCLUDE_TRUE) {
>>  	search_exclude_tags = notmuch_config_get_search_exclude_tags
>> -	    (config, &search_exclude_tags_length);
>> +				  (config, &search_exclude_tags_length);
>
> With the first 2 uncrustify does a good job, but this last one it disagrees
> how emacs(1) indents (and how it is currently indented in other notmuch
> source files) -- I'd leave the last (3rd) change out.

I actually think the uncrustify version is better, but I agree there is
not much point having a standard that isn't easily achievable with
emacs.  After a short struggle trying to understand CC-mode indentation,
I give up.

d

Thread: