Re: [PATCH] emacs: hello: fix accidental modification of widget-keymap

Subject: Re: [PATCH] emacs: hello: fix accidental modification of widget-keymap

Date: Sat, 21 Nov 2015 07:50:06 -0400

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: David Bremner


Mark Walters <markwalters1009@gmail.com> writes:

> In emacs24 we use make-composed-keymap. It seems that if only a single
> map is specified then emacs just resuses it rather than creating a
> copy of it. Thus use make-sparse-keymap to force a copy.
> ---
>
> pseudomyne and the diredful author thamer found that we modify
> widget-keymap in notmuch. We clearly don't want to, and I think we
> tried not to, but emacs was being clever and reused the old keymap
> rather than creating a new one.

I have tested this patch against the latest diredful.el and it seems to
be OK. Barring protests I'll apply it against release, and start to
build 0.21.1 ; not sure if we have any other suitable bug fixes to
include.

d

Thread: