Re: [PATCH 2/3] test: Deal with Emacs 27 switching to lexical scope by default

Subject: Re: [PATCH 2/3] test: Deal with Emacs 27 switching to lexical scope by default

Date: Mon, 27 Jul 2020 08:34:43 -0300

To: Jonas Bernoulli, notmuch@notmuchmail.org

Cc:

From: David Bremner

Jonas Bernoulli <jonas@bernoul.li> writes:

>  
> +(defvar notmuch-hello-mode-hook-counter -100)
> +(defvar notmuch-hello-refresh-hook-counter -100)
> +
>  (defadvice notmuch-search-process-filter (around pessimal activate disable)
>    "Feed notmuch-search-process-filter one character at a time."
>    (let ((string (ad-get-arg 1)))

This is overall fine, but if you were going to respin the series anyway
for something else, then a comment on the unusual initialization values
would not go amiss. Out of curiousity, why not nil?

d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

• Previous message (by thread): Re: [PATCH 3/3] test: Explicitly state that we want to sign with sender

Thread:

• Jonas Bernoulli—[PATCH 0/3] Adjust test for changes in Emacs 27 [inbox, unread]
  • Jonas Bernoulli—[PATCH 1/3] gitignore: Ignore generated sphinx.config [inbox, notmuch::moreinfo, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 1/3] gitignore: Ignore generated sphinx.config [inbox, unread]
      • Jonas Bernoulli—Re: [PATCH 1/3] gitignore: Ignore generated sphinx.config [inbox, unread]
  • Jonas Bernoulli—[PATCH 2/3] test: Deal with Emacs 27 switching to lexical scope by default [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH 3/3] test: Explicitly state that we want to sign with sender [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 3/3] test: Explicitly state that we want to sign with sender [inbox, unread]
  • Jonas Bernoulli—[PATCH 0/3] Adjust test for changes in Emacs 27 [inbox, unread]
    • Jonas Bernoulli—[PATCH 1/3] gitignore: Ignore generated sphinx.config [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
      • Tomi Ollila—Re: [PATCH 1/3] gitignore: Ignore generated sphinx.config [inbox, unread]
        • Jonas Bernoulli—Re: [PATCH 1/3] gitignore: Ignore generated sphinx.config [inbox, unread]
    • Jonas Bernoulli—[PATCH 2/3] test: Deal with Emacs 27 switching to lexical scope by default [inbox, notmuch::obsolete, notmuch::patch, unread]
      • David Bremner—Re: [PATCH 2/3] test: Deal with Emacs 27 switching to lexical scope by default [inbox, unread]
    • Jonas Bernoulli—[PATCH 3/3] test: Explicitly state that we want to sign with sender [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jonas Bernoulli—[PATCH v3 0/4] Adjust test for changes in Emacs 27 [inbox, unread]
    • Jonas Bernoulli—[PATCH v3 1/4] gitignore: Ignore generated sphinx.config [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v3 2/4] test: Deal with Emacs 27 switching to lexical scope by default [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v3 3/4] test: Remove misguided emacs testing utilities [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jonas Bernoulli—[PATCH v3 4/4] test: Explicitly state that we want to sign with sender [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v3 0/4] Adjust test for changes in Emacs 27 [inbox, unread]
      • Jonas Bernoulli—Re: [PATCH v3 0/4] Adjust test for changes in Emacs 27 [inbox, unread]