Re: [PATCH 1/3] ruby: add new Database.open_with_config

Subject: Re: [PATCH 1/3] ruby: add new Database.open_with_config

Date: Sun, 27 Jun 2021 15:02:55 -0300

To: Felipe Contreras, notmuch@notmuchmail.org

Cc:

From: David Bremner


Felipe Contreras <felipe.contreras@gmail.com> writes:

> +    ret = notmuch_database_open_with_config (database_path, mode,
> +					     config_path, profile, &db,
> +					     NULL);

I'm curious why you ignore the error_message ouput parameter. Of course
it's valid and supported for library users to do this, but this way
there is no way for users of the ruby bindings to retrieve the
additional information about the error. Particularly in the case of
Xapian exceptions, this can be helpful for debugging.

_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: