Re: [PATCH] Add 'd'elete keybinding to search and show views

Subject: Re: [PATCH] Add 'd'elete keybinding to search and show views

Date: Wed, 21 Apr 2010 19:25:43 -0400

To: Dirk Hohndel, notmuch@notmuchmail.org

Cc:

From: Jesse Rosenthal

Hi Dirk,

On Wed, 21 Apr 2010 16:16:03 -0700, Dirk Hohndel <hohndel@infradead.org> wrote:
> +	     (if delete
> +		 (notmuch-show-add-tag "deleted")))

The one thing I would suggest is adding a level of customizability,
instead of hardcoding in "deleted".
i.e.:
 
  (defvar notmuch-delete-tag "deleted")

and then:

  (if delete
      (notmuch-show-add-tag notmuch-delete-tag))


The less we force specific tags on users, it seems to me, the better.

Best,
Jesse

Thread: