Re: [PATCH] Do not query on notmuch-search exit

Subject: Re: [PATCH] Do not query on notmuch-search exit

Date: Tue, 23 Aug 2011 16:39:36 -0700

To: Michal Sojka, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins

On Mon, 22 Aug 2011 22:29:03 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> -	  (set-process-filter proc 'notmuch-search-process-filter))))
> +	  (set-process-filter proc 'notmuch-search-process-filter)
> +	  (set-process-query-on-exit-flag proc nil)))
> +      )

As very minor stylistic point, I think we tend to group all closing
parens together on the same line.  Otherwise I think this patch looks
great.

Thanks, Michal.

jamie.

• Previous message (by thread): Re: [PATCH] Do not query on notmuch-search exit

Thread:

• Michal Sojka—[PATCH] Do not query on notmuch-search exit [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Tomi Ollila—Re: [PATCH] Do not query on notmuch-search exit [inbox, unread]
    • Tomi Ollila—Re: [PATCH] Do not query on notmuch-search exit [inbox, unread]
      • Michal Sojka—Re: [PATCH] Do not query on notmuch-search exit [inbox, unread]
  • Jameson Graef Rollins—Re: [PATCH] Do not query on notmuch-search exit [inbox, unread]
    • Michal Sojka—Re: [PATCH] Do not query on notmuch-search exit [inbox, unread]
      • Michal Sojka—[PATCH] Do not query on notmuch-search exit [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jameson Graef Rollins—Re: [PATCH] Do not query on notmuch-search exit [inbox, signed, unread]
          • Michal Sojka—Re: [PATCH] Do not query on notmuch-search exit [inbox, notmuch::patch, notmuch::pushed, notmuch::review, unread]
            • Jameson Graef Rollins—Re: [PATCH] Do not query on notmuch-search exit [inbox, signed, unread]
              • Pieter Praet—Re: [PATCH] Do not query on notmuch-search exit [inbox, unread]
  • James Vasile—Re: [PATCH] Do not query on notmuch-search exit [inbox, unread]