Re: [PATCH] build: check .git directory existence in srcdir (for out-of-tree builds)

Subject: Re: [PATCH] build: check .git directory existence in srcdir (for out-of-tree builds)

Date: Sat, 05 Jul 2014 09:11:29 -0300

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: David Bremner


Tomi Ollila <tomi.ollila@iki.fi> writes:

> So that $(VERSION) and version.stamp uses the git-describe -based
> version data instead of the content of `version' file.
>
> For consistency also the git commands in Makefile[.local] target
> `verify-no-dirty-code' uses the git --git-dir=$srcdir/.git ...
> commands (inside ifeq($(IS_GIT),yes)). Attempting to make this
> target outside of the tree will fail in any case.

This seems to work OK; I wondered if an alternate method of setting (and
exporting) GIT_DIR from the top level makefile would work as well, and
be less intrusive?

d

Thread: