Re: [PATCH] emacs: Sort saved searches

Subject: Re: [PATCH] emacs: Sort saved searches

Date: Sun, 04 Sep 2011 01:02:03 +0300

To: Tomi Ollila

Cc: notmuch@notmuchmail.org

From: Jani Nikula


On Sat, 03 Sep 2011 14:56:09 +0300, Tomi Ollila <tomi.ollila@nixu.com> wrote:
> On Fri 02 Sep 2011 15:28, Jani Nikula <jani@nikula.org> writes:
> 
> > Display saved searches sorted, like tags are displayed.
> >
> > This only affects the display of the saved searches, not the order in which
> > they are stored in .emacs.
> >
> > Signed-off-by: Jani Nikula <jani@nikula.org>
> > ---
> 
> Fun! I reveresed the sorting order so I got 'unread' first ;). Well, I
> prefer to sort the value of the (customizable) variable
> 'notmuch-saved-searches' myself (unless there is another variable which
> also provides 'saved searches' into notmuch-hello buffer)... 

Well, this is obviously easy to customize... and indeed I've got a ready
patch to do just that... but I've been told before to avoid
customization and prefer sane defaults instead. So which do we want,
really? If you want sorting customizable, then I'll also include a patch
to make saving new saved searches append vs. prepend customizable too,
as that's important if you don't want sorting.

It's fine for me either way, really, with or without customization, as
long as one of these ways is upstreamed and I don't have to carry the
patches for myself...

BR,
Jani.


Thread: