Re: [PATCH v3 1/6] cli: new crypto structure to store crypto contexts and parameters, and functions to support it

Subject: Re: [PATCH v3 1/6] cli: new crypto structure to store crypto contexts and parameters, and functions to support it

Date: Wed, 23 May 2012 10:34:53 -0700

To: Jani Nikula

Cc: Notmuch Mail

From: Jameson Graef Rollins

On Tue, May 22 2012, Jani Nikula <jani@nikula.org> wrote:
>> +/* for the specified protocol return the context pointer (initializing
>> + * if needed) */
>> +GMimeCryptoContext *
>> +notmuch_crypto_get_context (notmuch_crypto_t *crypto, const char
> *protocol)
>> +{
>> +    GMimeCryptoContext *cryptoctx = NULL;
>
> Isn't GMimeCryptoContext gmime 2.6 specific? It's #ifdeffed elsewhere at
> least. Also affects the return type.

Yes, good catch, Jani.  Thank you.  Will fix.

>> +    if ((strcmp (protocol, "application/pgp-signature") == 0)
>> +       || (strcmp (protocol, "application/pgp-encrypted") == 0)) {
>
> Is protocol guaranteed to be lower case?

That's a good question.  I don't know.  I'll check and fix
appropriately.

jamie.

part-000.sig (application/pgp-signature)

Previous message (by thread): Re: [PATCH v3 1/6] cli: new crypto structure to store crypto contexts and parameters, and functions to support it

Thread:

Jameson Graef Rollins—[PATCH v3 0/6] cli: improved crypto internals [inbox, unread]
- Jameson Graef Rollins—[PATCH v3 1/6] cli: new crypto structure to store crypto contexts and parameters, and functions to support it [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jameson Graef Rollins—[PATCH v3 2/6] cli: modify show and reply to use new crypto struct [inbox, notmuch::obsolete, notmuch::patch, unread]
    - Jameson Graef Rollins—[PATCH v3 3/6] cli: modify mime_node_open to take new crypto struct as argument [inbox, notmuch::obsolete, notmuch::patch, unread]
      - Jameson Graef Rollins—[PATCH v3 4/6] cli: modify mime_node_context to use the new crypto struct [inbox, notmuch::obsolete, notmuch::patch, unread]
        Jameson Graef Rollins—[PATCH v3 5/6] cli: new crypto verify flag to handle verification [inbox, notmuch::obsolete, notmuch::patch, unread]
        Jameson Graef Rollins—[PATCH v3 6/6] cli: use new notmuch_crypto_get_context in mime-node.c [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jani Nikula—Re: [PATCH v3 1/6] cli: new crypto structure to store crypto contexts and parameters, and functions to support it [inbox, notmuch::review, unread]
    - Jameson Graef Rollins—Re: [PATCH v3 1/6] cli: new crypto structure to store crypto contexts and parameters, and functions to support it [inbox, signed, unread]