Re: [PATCH 2/2] notmuch-new: block database upgrades in default configuration.

Subject: Re: [PATCH 2/2] notmuch-new: block database upgrades in default configuration.

Date: Sun, 23 Mar 2014 16:54:47 -0700

To: Jani Nikula, David Bremner, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins


On Sun, Mar 23 2014, Jani Nikula <jani@nikula.org> wrote:
> We really have very few configuration options, and so far none of them
> are such that we could make the decision for the user. I think in this
> case pushing the responsibility to the user would be just *us* being
> paranoid. What does that tell our users?
>
> I also think the user should consider doing backups before upgrading
> notmuch in the first place. I am generally more concerned about the user
> doing a database dump of the old database version using the new notmuch
> than doing the upgrade. (Although in this case I think we're fine unless
> the user decides 'notmuch dump folder:important' is enough.)

Sorry for the delay responding to this.

I really think the right way to handle a database upgrade is:

* fail notmuch new (with appropriate message) if run in quiet mode
* prompt user yes/no to upgrade database otherwise

This will allow all users to acknowledge the upgrade and do the
appropriate thing, regardless of configuration, without adding a new
config option.

jamie.
part-000.sig (application/pgp-signature)

Thread: