Re: [PATCH] test/T360-symbol-hiding: use readelf in place of nm

Subject: Re: [PATCH] test/T360-symbol-hiding: use readelf in place of nm

Date: Sun, 13 Dec 2020 08:58:22 -0400

To: Tomi Ollila,


From: David Bremner

Tomi Ollila <> writes:

> On Fri, Dec 11 2020, David Bremner wrote:
>> It turns out that using nm -P isn't as portable as hoped. In particular on
>> architectures using ELF v1 (e.g. ppc64), the desired symbols end up in
>> the data section instead of text.
>> The test is currently only functional on ELF based architectures, so I
>> think it's legit to depend on readelf instead of nm.
>> The switch to readelf has the advantage that we can explicitely ask
>> for all of the symbols with global visibility, rather than grepping
>> for notmuch. That seems a more robust approach since it will catch any
>> strangely named global symbols.
> Looks good. I use this opportunity to mention that `sort | uniq` can be
> replaced with `sort -u`  :D

I actually did that, but then thought, there must be some reason we do
it this way, maybe portability? Having just checked, I see it's in POSIX
1003.1-2017 (and apparently earlier versions). So I guess it's most likely

Applied with s/sort|uniq/sort -u/ and one space deleted.
notmuch mailing list --
To unsubscribe send an email to