Re: [PATCH v2 03/10] ruby: improve general data get helper

Subject: Re: [PATCH v2 03/10] ruby: improve general data get helper

Date: Wed, 12 May 2021 19:38:25 -0300

To: Felipe Contreras, notmuch@notmuchmail.org

Cc: Ali Polatel, Austin Clements, Tomi Ollila, Ludovic LANGE, Daniel Kahn Gillmor

Felipe Contreras <felipe.contreras@gmail.com> writes:

> There's no need to do Check_Type, Data_Get_Struct calls
> rb_data_object_get(), which already does that.

Applied 1-3 to master.

d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Previous message (by thread): Re: [PATCH v2 10/10] ruby: new notmuch_rb_object_destroy() helper

Thread:

Felipe Contreras—[PATCH v2 00/10] ruby: object cleanups [inbox, unread]
- Felipe Contreras—[PATCH v2 01/10] ruby: add missing Data_Get_Notmuch helpers [inbox, notmuch::patch, notmuch::pushed, unread]
- Felipe Contreras—[PATCH v2 02/10] ruby: improve all Data_Get_Notmuch_* helpers [inbox, notmuch::patch, notmuch::pushed, unread]
- Felipe Contreras—[PATCH v2 03/10] ruby: improve general data get helper [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH v2 03/10] ruby: improve general data get helper [inbox, unread]
- Felipe Contreras—[PATCH v2 04/10] ruby: simplify data get helper [inbox, notmuch::moreinfo, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 04/10] ruby: simplify data get helper [inbox, unread]
    - Felipe Contreras—Re: [PATCH v2 04/10] ruby: simplify data get helper [inbox, unread]
- Felipe Contreras—[PATCH v2 05/10] ruby: fetch class name in case of error [inbox, notmuch::obsolete, notmuch::patch, unread]
- Felipe Contreras—[PATCH v2 06/10] ruby: add unlikely hint [inbox, notmuch::obsolete, notmuch::patch, unread]
- Felipe Contreras—[PATCH v2 07/10] ruby: create Data_Wrap_Notmuch_Object helper [inbox, notmuch::obsolete, notmuch::patch, unread]
- Felipe Contreras—[PATCH v2 08/10] ruby: move towards more modern RTypedData [inbox, notmuch::moreinfo, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 08/10] ruby: move towards more modern RTypedData [inbox, unread]
    - Felipe Contreras—Re: [PATCH v2 08/10] ruby: move towards more modern RTypedData [inbox, unread]
- Felipe Contreras—[PATCH v2 09/10] ruby: add all data types [inbox, notmuch::obsolete, notmuch::patch, unread]
- Felipe Contreras—[PATCH v2 10/10] ruby: new notmuch_rb_object_destroy() helper [inbox, notmuch::moreinfo, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 10/10] ruby: new notmuch_rb_object_destroy() helper [inbox, unread]
    - Felipe Contreras—Re: [PATCH v2 10/10] ruby: new notmuch_rb_object_destroy() helper [inbox, unread]
- Felipe Contreras—Re: [PATCH v2 00/10] ruby: object cleanups [inbox, unread]
  - Felipe Contreras—Re: [PATCH v2 00/10] ruby: object cleanups [inbox, unread]
    - Tomi Ollila—Re: [PATCH v2 00/10] ruby: object cleanups [inbox, unread]