Re: [PATCH 2/3] ruby: add keyword arguments to db.query

Subject: Re: [PATCH 2/3] ruby: add keyword arguments to db.query

Date: Sun, 23 May 2021 09:29:41 -0300

To: Felipe Contreras, notmuch@notmuchmail.org

Cc: Ludovic LANGE, Stefano Zacchiroli

From: David Bremner

Felipe Contreras <felipe.contreras@gmail.com> writes:

> That way we don't need pass them to the query object ourselves.

LGTM, but when I tried to resolve the conflicts I messed something up
and the ruby sort test(s) started failing.  Rebase please?

d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

• Previous message (by thread): Re: [PATCH 3/3] test: ruby: simplify basic tests

Thread:

• Felipe Contreras—[PATCH 0/3] ruby: improve db.query [inbox, unread]
  • Felipe Contreras—[PATCH 1/3] ruby: use notmuch_exclude_t enum [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH 1/3] ruby: use notmuch_exclude_t enum [inbox, unread]
  • Felipe Contreras—[PATCH 2/3] ruby: add keyword arguments to db.query [inbox, notmuch::moreinfo, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 2/3] ruby: add keyword arguments to db.query [inbox, unread]
      • Felipe Contreras—Re: [PATCH 2/3] ruby: add keyword arguments to db.query [inbox, unread]
  • Felipe Contreras—[PATCH 3/3] test: ruby: simplify basic tests [inbox, notmuch::patch, notmuch::wontfix, unread]
    • David Bremner—Re: [PATCH 3/3] test: ruby: simplify basic tests [inbox, unread]
      • Felipe Contreras—Re: [PATCH 3/3] test: ruby: simplify basic tests [inbox, unread]
        • David Bremner—Re: [PATCH 3/3] test: ruby: simplify basic tests [inbox, unread]
          • Felipe Contreras—Re: [PATCH 3/3] test: ruby: simplify basic tests [inbox, unread]