Re: [PATCH v2 0/7] lib: replace the message header parser with gmime

Subject: Re: [PATCH v2 0/7] lib: replace the message header parser with gmime

Date: Sun, 02 Feb 2014 15:03:52 +0200

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Jani Nikula


On Wed, 15 Jan 2014, David Bremner <david@tethera.net> wrote:
> Jani Nikula <jani@nikula.org> writes:
>
>> This is v2 of id:cover.1381948853.git.jani@nikula.org with more polish.
>>
>> Patches 1-4 do prep work to fix some of the differences in the parsers
>> in advance. Arguably they are not that bad regardless of the parser
>> change.
>>
>> Patches 5-6 actually make the change. Having two patches is a somewhat
>> artificial division, but perhaps makes it easier to review.
>>
>
> I had a quick look at these changes, and nothing jumped out at me. I'd
> appreciate a second pair of eyes on them.

Anyone?

Patches 1-4 are pretty straightforward prep work, IMHO useful on their
own too. It would help just to get them reviewed and merged first.

BR,
Jani.


>
> I ran the performance suite, and there is only one message (in version
> 0.4 of the corpus) newly classified as non-mail. Of course I did clean
> up the corpus a bunch from 0.3 to 0.4. I didn't see any shocking changes
> in performance before and after the patches. I only had patience enough
> to run twice in both cases.
>
> d

Thread: