On Thu, Oct 30 2014, Tomi Ollila wrote: > On Thu, Oct 30 2014, Mark Walters <markwalters1009@gmail.com> wrote: > >> On Mon, 27 Oct 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote: >>> This adds an algorithm to filter out duplicate addresses from address >>> outputs (sender, receivers). The algorithm can be configured with >>> --filter-by command line option. >>> >>> The code here is an extended version of a patch from Jani Nikula. >> >> Hi >> >> As this is getting into the more controversial bike shedding region I >> wonder if it would be worth splitting this into 2 patches: the first >> could do the default dedupe based on name/address and the second could >> do add the filter-by options. >> >> I think the default deduping is obviously worth doing but I am not sure >> about the rest. In any case I think the default deduping could go in >> pre-freeze but I would recommend the rest is left until after. > > I can agree with that, but there is one hard thing to resolve: > "naming things"(*) > > (*) http://martinfowler.com/bliki/TwoHardThings.html > > With all rest ignored (sorry no time to work on this in more detail now), > this default deduping could be done with single argument '--unique'... I would agree that --unique is slightly better than --filter-by, but I don't see what is so attractive on having no deduplication at all. Anyway, I'll keep it in v5 as it is now and we can add --unique=no/none/whatever later. -Michal