Re: [PATCH] emacs/show: force notmuch-show-buttonise-links to act on lines

Subject: Re: [PATCH] emacs/show: force notmuch-show-buttonise-links to act on lines

Date: Tue, 11 Oct 2016 08:25:35 -0300

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: David Bremner


Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Mon, Oct 10 2016, David Bremner <david@tethera.net> wrote:
>
>> This seems to fix a problem with emacs 25 creating partial buttons by
>> calling n-s-b-l with a region that does not include the whole button.
>> I'm not 100% sure it's legit to act outside the region passed by
>> jit-lock, but goto-address-fontify-region (where I borrowed the code
>> from) already does this, so this patch to not make things worse.
>> ---
>
> Applies cleanly and fixes the test in question on fedora 24

I was a bit worried about the performance impact, but according to
profiling it doesn't really seem to be a hotspot, 0% in profiling of
rending a 600 message thread. So unless I hear some cogent objections,
I'm going ahead with this.

d

Thread: