Re: [notmuch] [PATCH 4/9] Factor out message buffer mgmt from notmuch-show-view-all-mime-parts

Subject: Re: [notmuch] [PATCH 4/9] Factor out message buffer mgmt from notmuch-show-view-all-mime-parts

Date: Fri, 27 Nov 2009 21:23:19 -0800

To: Carl Worth, camalot@picnicpark.org, notmuch@notmuchmail.org

Cc: Keith Amidon

From: Alexander Botero-Lowry


On Fri, 27 Nov 2009 21:10:42 -0800, Carl Worth <cworth@cworth.org> wrote:
> On Fri, 27 Nov 2009 05:30:10 -0800, camalot@picnicpark.org wrote:
> > From: Keith Amidon <keith@nicira.com>
> > 
> > The ability to temporarily create a buffer containing only the
> > contents of the currently selected message in notmuch show mode is
> > generally useful.  This commit factors the majority of the code
> > required to do so out of notmuch-show-view-all-mime-parts into a macro
> > called with-current-notmuch-show-message and rewrites the original
> > function in terms of the macro.
> > 
> > A future set of commits will provide additional functionality using
> > the macro as well.
> 
> Hurrah! I'm glad to see that you are wholly more capable with emacs lisp
> than I am. I knew of lisp macros of course, but didn't know the actual
> syntax for writing one.
> 
I actually did something similar for my html support. except I used
`with-temp-buffer' macro instead. I'm hoping that the need to ever
actually use the raw message buffer directly goes away, so I think it
would be better to use with-temp-buffer in your macro instead of the
named buffer.

Alex

Thread: