Re: [PATCH] build: Support Mac OS X 10.6.8

Subject: Re: [PATCH] build: Support Mac OS X 10.6.8

Date: Wed, 01 Jul 2015 10:29:08 -0500

To: Nate Eagleson, notmuch@notmuchmail.org

Cc:

From: J. Lewis Muir


On 6/30/15 4:29 PM, Nate Eagleson wrote:
> +# Mac OS X 10.6 has a built-in libutil.dylib that prevents ld from
> +# picking up notmuch's libutil.a. The best way to prefer our local
> +# libutil.a is to specify it via absolute path, which should work on
> +# all supported OSes.
> +LIBUTIL_PATH=${srcdir}/util/libutil.a

Hi, Nate.

I think it would be better to make the above comment not specific to OS
X, but instead just refer to "systems that have a built-in util library"
or similar.  For example, NetBSD has a built-in util library [1].  I
don't have access to a FreeBSD system, but it looks like FreeBSD might
have a built-in util library too [2].

Similarly for the one-line commit summary since this change is not
specific to OS X.

Regards,

Lewis

[1] http://netbsd.gw.com/cgi-bin/man-cgi?libutil++NetBSD-current
[2] http://svnweb.freebsd.org/base/head/lib/libutil/Makefile?view=markup

Thread: