Re: [PATCH 0/3] General fixes

Subject: Re: [PATCH 0/3] General fixes

Date: Sat, 02 Nov 2013 06:17:17 -0600

To: David Bremner, Felipe Contreras, notmuch@notmuchmail.org

Cc:

From: Felipe Contreras


David Bremner wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
> 
> > Felipe Contreras (3):
> >   query: bind queries to database objects
> >   ruby: allow build with RUNPATH
> >   ruby: bind database close()/destroy() properly
> 
> I agree with the discussion on IRC that the change in the first patch
> makes sense.

Shall I push it to the master branch then?

> It would be nice to have a bit more explanation in the commit message of
> the second message; at least to point out that (iiuc) this is not a
> really a ruby specific thing, just a standard ld.so feature.

I don't really care that much about patch #2, but #3 should probably be
applied.

The important is #1 though.

-- 
Felipe Contreras

Thread: