Re: [notmuch] [PATCH] Add post-add and post-tag hooks

Subject: Re: [notmuch] [PATCH] Add post-add and post-tag hooks

Date: Wed, 23 Dec 2009 07:57:21 +0100

To: Olly Betts

Cc: notmuch@notmuchmail.org

From: Tomas Carnecky


On 12/23/09 12:02 AM, Olly Betts wrote:
> Tomas Carnecky writes:
>> #if defined(__sun__)
>> 	... sprintf, stat etc
>> #else
>> 	(void) path;
>> 	return dirent->d_type == DT_DIR;
>> #endif
>
> Rather than a platform-specific check, it would be better to check if DT_DIR
> is defined.
>
> Beware that even on Linux (where the d_type field is present), it may always
> contain DT_UNKNOWN for some filesystems, so you really should check for that
> case and fall back to using stat() instead.

Currently configure is a simple shell script and not some autoconf 
magic. And I don't know how eager Carl is to use autoconf, scons, cmake 
or similar.

tom


Thread: