Re: [PATCH 08/10] notmuch-config: header for index() prototype (Solaris support)

Subject: Re: [PATCH 08/10] notmuch-config: header for index() prototype (Solaris support)

Date: Sun, 04 Nov 2012 20:52:59 -0800

To: Tomi Ollila

Cc: notmuch@notmuchmail.org

From: Blake Jones


>> On Sun, 04 Nov 2012, Blake Jones <blakej@foo.net> wrote:
>>> Linux, FreeBSD, and Solaris all expect to find the prototype for
>>> "index()" in <strings.h>.  On some operating systems, including
>>> <string.h> is sufficient to get the prototype, but that's not the case
>>> on Solaris.  This patch just modifies notmuch-config.c to include
>>> <strings.h> to get the prototype.
>>
>> We should probably just nuke index() and use strchr() instead.
> 
> indeed!

That was my initial preference, but I didn't know if there was anyone
who was committed to the BSD name.  Given that two more people think
it's a good idea, I'll do that instead.

Blake

Thread: