[PATCH 2/2] emacs/hello: fix one case of passing hide-excluded

Subject: [PATCH 2/2] emacs/hello: fix one case of passing hide-excluded

Date: Sun, 15 Jun 2025 17:12:35 -0300

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: David Bremner

In the search box (and recent searches), notmuch-search-hide-excluded
was not being passed to notmuch-search. This means that excluded
messages were always shown in the results. Fix this by passing the
extra argument.
---
 emacs/notmuch-hello.el            | 2 +-
 test/T461-emacs-search-exclude.sh | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 67c805a8..eb5d618a 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -438,7 +438,7 @@ supported for \"Customized queries section\" items."
       (setq search (string-trim search))
       (let ((history-delete-duplicates t))
 	(add-to-history 'notmuch-search-history search)))
-    (notmuch-search search notmuch-search-oldest-first)))
+    (notmuch-search search notmuch-search-oldest-first notmuch-search-hide-excluded)))
 
 (defun notmuch-hello-add-saved-search (widget &rest _event)
   (let ((search (widget-value (widget-get widget :parent)))
diff --git a/test/T461-emacs-search-exclude.sh b/test/T461-emacs-search-exclude.sh
index 821dd49f..be557cda 100755
--- a/test/T461-emacs-search-exclude.sh
+++ b/test/T461-emacs-search-exclude.sh
@@ -24,7 +24,6 @@ test_emacs '(notmuch-hello)
 test_expect_equal_file $EXPECTED/notmuch-search-tag-inbox-without-excluded OUTPUT
 
 test_begin_subtest "Search from search box doesn't contain excluded mail by default"
-test_subtest_known_broken
 test_emacs '(notmuch-hello)
 	    (goto-char (point-min))
 	    (re-search-forward "Search:")
-- 
2.47.2

_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: