[PATCH 1/2] lib/message: check message type before deleting document

Subject: [PATCH 1/2] lib/message: check message type before deleting document

Date: Thu, 20 Jul 2023 09:08:00 -0300

To: notmuch@notmuchmail.org

Cc: ukleinek@debian.org

From: David Bremner

It isn't really clear how this worked before. Traversing the terms of
a document after deleting it from the database seems likely to be
undefined behaviour at best
 lib/message.cc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/message.cc b/lib/message.cc
index 53f35dd1..46638f80 100644
--- a/lib/message.cc
+++ b/lib/message.cc
@@ -1397,14 +1397,15 @@ _notmuch_message_delete (notmuch_message_t *message)
 	Xapian::PostingIterator thread_doc, thread_doc_end;
 	Xapian::PostingIterator mail_doc, mail_doc_end;
-	message->notmuch->writable_xapian_db->delete_document (message->doc_id);
 	/* look for a non-ghost message in the same thread */
 	/* if this was a ghost to begin with, we are done */
 	private_status = _notmuch_message_has_term (message, "type", "ghost", &is_ghost);
 	if (private_status)
 	    return COERCE_STATUS (private_status,
 				  "Error trying to determine whether message was a ghost");
+	message->notmuch->writable_xapian_db->delete_document (message->doc_id);
 	if (is_ghost)

notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org