We don't need a FileNames enumerable object only for a small number of strings, we can just get them directly. This iterator is meant to be transient and works only once, so we better just iterate it once. This is the same approach I took with the Tags object, I was waiting for feedback on that approach but since there isn't any and there's no reason this shouldn't work, here's the same for Filenames. Felipe Contreras (3): ruby: add filenames helper ruby: filenames: return string array directly ruby: remove FileNames object bindings/ruby/defs.h | 9 +------ bindings/ruby/directory.c | 4 +-- bindings/ruby/filenames.c | 51 +++------------------------------------ bindings/ruby/init.c | 14 ----------- bindings/ruby/message.c | 2 +- 5 files changed, 8 insertions(+), 72 deletions(-) -- 2.39.2.13.g1fb56cf030 _______________________________________________ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-leave@notmuchmail.org