[PATCH] doc: add dep. on stamp file for rebuilding gzipped man pages.

Subject: [PATCH] doc: add dep. on stamp file for rebuilding gzipped man pages.

Date: Fri, 24 Dec 2021 12:20:31 -0400

To: Daniel Kahn Gillmor, David Bremner, Notmuch Mail

Cc:

From: David Bremner

In [1] Daniel observed that the gzipped man pages were only being
rebuild every second time when building with `make -j4'. This may be
caused by a race condition between sphinx-build rebuilding the roff
files and the recipe to gzip them. This commit sequentializes these
two steps by making the stamp file a prerequisite for (all of) the
gzip files.

[1]: id:87tveotn1g.fsf@fifthhorseman.net
---
 doc/Makefile.local | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/Makefile.local b/doc/Makefile.local
index c2ae1743..d43ef269 100644
--- a/doc/Makefile.local
+++ b/doc/Makefile.local
@@ -117,6 +117,11 @@ build-man:
 install-man:
 	@echo "No sphinx, will not install man pages."
 else
+
+# it should be safe to depend on the stamp file, because it is created
+# after all roff files are moved into place.
+${MAN_GZIP_FILES}: ${DOCBUILDDIR}/.roff.stamp
+
 build-man: ${MAN_GZIP_FILES}
 install-man: ${MAN_GZIP_FILES}
 	mkdir -m0755 -p "$(DESTDIR)$(mandir)/man1"
-- 
2.34.1

_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: