[PATCH v2 3/3] test/new: replace use of gdb in vanishing file test

Subject: [PATCH v2 3/3] test/new: replace use of gdb in vanishing file test

Date: Thu, 28 Oct 2021 10:46:25 -0300

To: Tomi Ollila, David Bremner, notmuch@notmuchmail.org


From: David Bremner

Unlike the similar change in T060-new, no symlink creation is needed
 test/T050-new.sh | 35 +++++++++++++++--------------------
 1 file changed, 15 insertions(+), 20 deletions(-)

diff --git a/test/T050-new.sh b/test/T050-new.sh
index 1141c1e3..fd1a7695 100755
--- a/test/T050-new.sh
+++ b/test/T050-new.sh
@@ -368,31 +368,26 @@ chmod u+w ${MAIL_DIR}/.notmuch/xapian/*.*
 test_expect_equal "$output" "A Xapian exception occurred opening database"
+make_shim dif-shim<<EOF
+#include <notmuch-test.h>
+WRAP_DLFUNC(notmuch_status_t, notmuch_database_index_file, \
+ (notmuch_database_t *database, const char *filename, notmuch_indexopts_t *indexopts, notmuch_message_t **message))
+  if (unlink ("${MAIL_DIR}/vanish")) {
+     fprintf (stderr, "unlink failed\n");
+     exit(42);
+  }
+  return notmuch_database_index_file_orig (database, filename, indexopts, message);
 test_begin_subtest "Handle files vanishing between scandir and add_file"
 # A file for scandir to find. It won't get indexed, so can be empty.
 touch ${MAIL_DIR}/vanish
-# Breakpoint to remove the file before indexing
-cat <<EOF > notmuch-new-vanish.gdb
-set breakpoint pending on
-set logging file notmuch-new-vanish-gdb.log
-set logging on
-break notmuch_database_index_file
-shell rm -f ${MAIL_DIR}/vanish
-${TEST_GDB} --batch-silent --return-child-result -x notmuch-new-vanish.gdb \
-    --args notmuch new 2>OUTPUT 1>/dev/null
+notmuch_with_shim dif-shim new 2>OUTPUT 1>/dev/null
 echo "exit status: $?" >> OUTPUT
-# Clean up the file in case gdb isn't available.
-rm -f ${MAIL_DIR}/vanish
 Unexpected error with file ${MAIL_DIR}/vanish
 add_file: Something went wrong trying to read or write a file

notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org